Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double free() corruption due to config #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 17, 2024

Hey Simon,

the attached patch fixes a double free() corruption leading to a crash
during startup of dnsmasq. The crash can be reproduced by using a
rev-server addresses with a prefix length != {8,16,24,32}, e.g.

rev-server=192.168.0.0/25,home.mydomain.com

The crash is caused by freeing too early (within the loop). The crash
does not happen for prefix lengths {8,16,24,32} as the loop runs only
once. However, for other prefixes, the loop runs more often (e.g. 128x
for /25 networks as above).

Best,
Dominik

Tracked here: https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2024q2/017606.html

…ver addresses with prefix lengths != {8,16,24,32}

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER mentioned this pull request Jul 15, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant