Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Go 1.21 as the minimum version #32

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Specify Go 1.21 as the minimum version #32

merged 2 commits into from
Jan 19, 2024

Conversation

picatz
Copy link
Owner

@picatz picatz commented Jan 19, 2024

This PR aims to fix #31 by specifying that 1.21 is the minimum version of Go required to compile packages in this module. While I was at it, I ran go mod tidy, which maybe wasn't necessary.

Note

In 1.21, the (*go/types.Package).GoVersion method was added to enable individual "checkers" to be able to find out the Go version associated with a given package (golang/go#61175). We use that new method here.

@picatz picatz merged commit ca0546c into main Jan 19, 2024
1 check passed
@picatz picatz deleted the fix-31 branch January 19, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This module requires Go 1.21 to build, but go.mod file declares Go 1.19 as minimum version
1 participant