Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement piped plugin service decrypt secret endpoint #5019

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jul 2, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 18.30986% with 58 lines in your changes missing coverage. Please review.

Project coverage is 22.45%. Comparing base (1258c8d) to head (0408802).
Report is 23 commits behind head on master.

Files Patch % Lines
pkg/app/pipedv1/cmd/piped/grpcapi/plugin_api.go 26.53% 36 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5019      +/-   ##
==========================================
- Coverage   22.45%   22.45%   -0.01%     
==========================================
  Files         520      521       +1     
  Lines       56852    56919      +67     
==========================================
+ Hits        12766    12779      +13     
- Misses      43060    43114      +54     
  Partials     1026     1026              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit f955dea into master Jul 19, 2024
17 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the add-decrytion-plugin-endpoint branch July 19, 2024 05:13
This was referenced Jul 29, 2024
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants