Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement POC for planner of pipedv1 #5062

Closed
wants to merge 2 commits into from

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

This PR provides POC implementation for the Planner of pipedv1 (piped side). The logic of building plan as follow

// The strategy determination logic is based on the following order:
//   - Direct trigger via web console
//   - Force quick sync if there is no pipeline specified
//   - Force pipeline if the `spec.planner.alwaysUsePipeline` was configured
//   - CommitMatcher ensure pipeline/quick sync based on the commit message
//   - Force quick sync if there is no previous deployment (aka. this is the first deploy)
//   - Based on PlannerService.DetermineStrategy returned by plugins

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 179 lines in your changes missing coverage. Please review.

Project coverage is 22.64%. Comparing base (aaf272b) to head (331dece).

Files Patch % Lines
pkg/app/pipedv1/controller/planner.go 0.00% 179 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5062      +/-   ##
==========================================
- Coverage   22.73%   22.64%   -0.09%     
==========================================
  Files         407      407              
  Lines       43123    43291     +168     
==========================================
  Hits         9803     9803              
- Misses      32542    32710     +168     
  Partials      778      778              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202
Copy link
Member Author

Close due to interface changed 🆗

@khanhtc1202 khanhtc1202 deleted the planner-controller-impl-poc branch September 20, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant