POC Piped v1 planner with plugin deployment interface #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
…c-pipedv1-planner Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
requested review from
nghialv,
kentakozuka,
ffjlabo,
t-kikuc and
Warashi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5111 +/- ##
==========================================
- Coverage 22.82% 22.78% -0.05%
==========================================
Files 409 409
Lines 43343 43720 +377
==========================================
+ Hits 9895 9961 +66
- Misses 32670 32975 +305
- Partials 778 784 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
commented
Aug 6, 2024
| @@ -223,6 +223,7 @@ type PipelineStage struct { | |||
| Name model.Stage | |||
| Desc string | |||
| Timeout Duration | |||
| With json.RawMessage | |||
There was a problem hiding this comment.
Only this part is the only change that not under the pipedv1 directory. This is for packing stage configuration (not unmarshall) and pass it as is to the plugin.
t-kikuc
approved these changes
Aug 6, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: