-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multiple observer #40
Conversation
This enables using Prisma as both type and value.
150b562
to
e71da0a
Compare
}), | ||
); | ||
} catch (e) { | ||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this check still needed? if so, we might also need to leave a comment about the reason for future readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, Manual logging for consumed exceptions would be needed. (for debugging situations)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're checking to see if there's any other exceptions missed, that might happen in some way. Regarding the log, yes I will keep in mind 😄
e71da0a
to
9a4aa84
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Now, observer ignores unique constraint failure on event insert, and It is now able to use multiple observers simultanously.
Also, prisma-shim now exports Prisma namespace as default export, which enables Prisma to be referenced both as type and value.