Feature merkle trie proof #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sircoon4
commented
Jul 17, 2024
•
sircoon4
commented
- Added merkle trie inclusion proof for libplanet as precompiled contract.
- Included tests for 4 success cases and 4 failure(return false) cases.
eseiker
reviewed
Jul 18, 2024
eseiker
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
LGTM with some comments
- not sure core/vm/libplanet is fine path
- seems there's a convention with RequiredGas to be placed in protocol_params.go
Line 1197 in 4a64d62
op-geth/params/protocol_params.go
Line 169 in 4a64d62
|
@eseiker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.