Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unexport GetPathBit #26

Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat: unexport GetPathBit #26

merged 1 commit into from
Sep 26, 2023

Conversation

h5law
Copy link
Collaborator

@h5law h5law commented Sep 25, 2023

Summary generated by Reviewpad on 25 Sep 23 19:45 UTC

This pull request updates the code by unexporting the GetPathBit function. It modifies multiple files, including proofs.go, smt.go, and utils.go. The changes involve replacing all occurrences of GetPathBit with the newly named function getPathBit. Overall, the patch improves code readability and maintainability by limiting the visibility of GetPathBit.

@h5law h5law requested a review from Olshansk September 25, 2023 19:45
@h5law h5law self-assigned this Sep 25, 2023
@reviewpad reviewpad bot added small Pull request is small waiting-for-review This PR is currently waiting to be reviewed labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c5998f1) 84.77% compared to head (9a79d43) 84.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files           8        8           
  Lines        1241     1241           
=======================================
  Hits         1052     1052           
  Misses        138      138           
  Partials       51       51           
Files Coverage Δ
proofs.go 88.46% <100.00%> (ø)
utils.go 94.28% <100.00%> (ø)
smt.go 80.03% <90.90%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h5law h5law merged commit 1df1f48 into main Sep 26, 2023
7 checks passed
@h5law h5law deleted the unexport_path_bit branch September 26, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review This PR is currently waiting to be reviewed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants