Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `Digest::CRC16DNP #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix `Digest::CRC16DNP #40

wants to merge 1 commit into from

Commits on Jul 7, 2023

  1. Fix `Digest::CRC16DNP 

      - Set `XOR_MASK` instead of flipping bits in `Digest::CRC16DNP#finish`.
  - `Digest::CRC16DNP#update` does a right bit shift in `lib/digest/crc16_dnp.rb`.
    However, the C implementation did a left bit shift.
    For reference, CRC-16/DNP seems to input bits in reverse order (lower bits).
    https://reveng.sourceforge.io/crc-catalogue/16.htm#crc.cat.crc-16-dnp
    @dearblue
    dearblue committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    90d6cee View commit details
    Browse the repository at this point in the history