Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team 10 translation documents #34

Closed
wants to merge 4 commits into from

Conversation

caotaiming
Copy link

@caotaiming caotaiming commented Jul 24, 2018

#24 group 10 translation

@zl117
Copy link

zl117 commented Jul 24, 2018

Comments from group 1:
some minor mistakes for the long translation:

  1. Line 10: "an" internal toobox not "a"
  2. Line 40 : "it is even nessary" there is a typo, which should be necesary
  3. Line 40 : "container technology must have the compatibility of", we found no usage of this, normally compatible goes with "with", could be switched to "must be compatible with"
  4. Line 40 : "avoid develop" -> "avoid developing"
  5. Line 42 : "transition into" -> make a transition to , the original sentence lacks a verb
  6. Line 106 : "For most applications which are relied heavily on the operation system" should not use passive tense, should be "For most applications that rely heavily..."
  7. Line 142 : "support LXCFS implement" -> "support LXCFS to implement"
    If we are wrong, let us know, thank you!

Signed-off-by: 泰铭曹 <[email protected]>
@RuiteGuo
Copy link

This version is the earliest version. After review we have already fixed the majority issues you mentioned and we haven't been able to update it. By the way, transition itself is a verb.

@zl117
Copy link

zl117 commented Jul 24, 2018

Transition is a verb, thank you for pointing that out

@heranyu
Copy link

heranyu commented Jul 24, 2018

  1. kubectl exec/attach/port-forward is a command
  2. 第五点”.Then reply to the http request, “缺少主语,中间应该为,
  3. After the Stream Server obtains the specified number of Streams, call the Container Manager's CreateExec and startExec methods in turn, performed the exec operation on the target container, and forwarded the IO stream to the corresponding stream. 这句话缺少主语

### 6. IO stream processing

Kubernetes provides functions such as kubectl exec/attach/port-forward to enable direct interaction between the user and a specific Pod or container, as showned below:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo : showned

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文中文就没有主语
很多技术性文档都有此类无主语句子只作为步骤性指导,用于描述动作,告诉读者怎样操作
不然每个句子前加一you can/ you should blah blah会让文档显得非常冗余

Stderr bool // Whether to include Stderr flow
}
```
2. Surprisingly, CRI Manager's `Exec` method does not directly call Container Manager and execute the exec command on the target container, but instead calls the built-in Stream Server's `GetExec`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove but

@starnop
Copy link
Contributor

starnop commented Aug 21, 2018

Too many commits to be able to merge.

@starnop starnop closed this Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants