[Feat] 지원서 제목 수정 API #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,4 +25,10 @@ public ApiResponse<Object> createApplication() { | |||
|
|
|||
| return ApiResponse.success(SuccessCode.APPLICATION_CREATE_SUCCESS, applicationId); | |||
| } | |||
|
|
|||
| @PatchMapping("/{applicationId}") | |||
| public ApiResponse<Object> updateApplicationTitle(@RequestParam Long applicationId, @RequestBody UpdateApplicationTitleRequestDto requestDto) { | |||
There was a problem hiding this comment.
Dto 이름 domain 이름으로 시작되게 통일시켜주면 좋을 것 같아요! -> ApplicationTitleUpdateRequestDto
| @PatchMapping("/{applicationId}") | ||
| public ApiResponse<Object> updateApplicationTitle(@RequestParam Long applicationId, @RequestBody UpdateApplicationTitleRequestDto requestDto) { | ||
| applicationService.updateApplicationTitle(applicationId, requestDto); | ||
| return ApiResponse.success(SuccessCode.APPLICATION_UPDATE_SUCCESS); |
There was a problem hiding this comment.
요거 successCode 이름도 title 업데이트로 명시시켜주는게 어떨까요?? 메모 업데이트도 있으니!
| Application application = applicationRepository.findById(applicationId) | ||
| .orElseThrow(() -> new NotFoundException(ErrorCode.NO_ID)); | ||
|
|
||
| application.setTitle(requestDto.getTitle()); |
There was a problem hiding this comment.
setter를 쓰는 것보단 updateTitle 함수를 만들어서 업데이트시켜주는게 좋을 것 같습니다. 스프링부트에서 setter는 값을 생성하는 건지, 수정하는건지 의도를 알기가 어려워 지양하는게 좋다고 합니다!
Seokyeong237
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
🧾 Describe your changes
지원서 제목 수정 API 기능 구현
📚 Etc