chore: refactor test suites #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
Aug 23, 2024
rschristian
commented
Aug 23, 2024
Comment on lines
+9
to
+10
| jsxFactory: 'h', | ||
| jsxFragment: 'Fragment', |
There was a problem hiding this comment.
The esbuild plugin doesn't support configuring the automatic transform at this time, hence the pragma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to
uvufor Node/non-browser tests and@web/test-runnerfor our new browser tests. Gives us better ESM support over Jest, dropsjsdomand the few hacks we needed to support it, and now we have JSX in our browser tests.It does mean different assertion libraries are used in browser vs Node, but both do pretty well in their own lane so I'm happy enough with it.