6.x - string.expandWildcards implementation #1889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@starkos or @samsinsane this look right to you? I'm not as well versed in the core premake libraries as yall. It LGTM, but I'd like one of yall to look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides an implementation for
string.expandWildcards.How does this PR change Premake's behavior?
The function will no longer return placeholders and will act as it should. Uses
string.patternFromWildcardsinternally.Anything else we should know?
Since
string.patternFromWildcardsis implemented in C I was unsure if the todo calling for this function to be moved to C is still applicable. If it is, I'd be able to move it either in another commit in this pr or by making a new pr. Also, I believe this implementation is applicable topath.expandWildcards, however, it breaks a few tests in the field module so it requires a bit more looking into.Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!