Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term.clearToEndOfLine and term.moveLeft API additions. #2253

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Sep 19, 2024

What does this PR do?

Adds term.clearToEndOfLine and term.moveLeft APIs to term.

Anything else we should know?

These depend on ANSI escape codes, which from what I've read Windows now supports.

Haven't tested it on Windows yet and I think support for it needs to be explicitly enabled: https://superuser.com/a/1300251

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@@ -491,7 +491,8 @@ module.exports = {
'term.getTextColor',
'term.popColor',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'term.moveLeft' is missing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants