Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Prettier v2 and plugin-tailwindcss problem #3038

Merged
merged 8 commits into from
Jun 22, 2023

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Jun 22, 2023

Fixes #3036

This PR makes only using Prettier v3 or higher, run an instance of Prettier in a worker.

  • Run tests
  • Update the CHANGELOG.md with a summary of your changes

@sosukesuzuki sosukesuzuki changed the title Temporary fix for prettier-plugin-tailwindcss problem Fix for Prettier v2 and plugin-tailwindcss problem Jun 22, 2023
@sosukesuzuki sosukesuzuki requested a review from fisker June 22, 2023 07:16
@sosukesuzuki sosukesuzuki marked this pull request as ready for review June 22, 2023 07:16
@auto-assign auto-assign bot requested a review from ntotten June 22, 2023 07:16
@ntotten ntotten merged commit a450fd5 into prettier:main Jun 22, 2023
9 checks passed
@mreduar
Copy link

mreduar commented Jun 22, 2023

The merging of this PR brought back error #3020 or #3031

["INFO" - 1:39:28 PM] Extension Name: esbenp.prettier-vscode.
["INFO" - 1:39:28 PM] Extension Version: 9.16.0.
["INFO" - 1:39:28 PM] Attempted to load Prettier module from /var/www/html/node_modules/prettier
["ERROR" - 1:39:28 PM] Failed to load module. If you have prettier or plugins referenced in package.json, ensure you have run `npm install`
["ERROR" - 1:39:28 PM] Cannot load Prettier version from package.json
Error: Cannot load Prettier version from package.json
    at t.ModuleResolver.loadPrettierVersionFromPackageJson (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:3820)
    at t.ModuleResolver.getPrettierInstance (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:5025)
    at t.default.handleActiveTextEditorChanged (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:10626)
    at t.default.handleActiveTextEditorChangedSync (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:10228)
    at t.default.registerDisposables (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:13071)
    at /root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:81163
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Some time ago I had the problem, I solved it by adding "prettier.prettierPath": "./node_modules/prettier", but it doesn't work anymore in the latest version. I had to go back to the previous version 9.15. Last night everything was working fine.

@sosukesuzuki
Copy link
Member Author

sosukesuzuki commented Jun 22, 2023

@mreduar Your problem is a different from #3020. Please open new issue.

@vsiao
Copy link
Contributor

vsiao commented Jun 23, 2023

filed #3041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not formatting on 9.15.0 when using plugin
4 participants