Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor field tests #166

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Refactor field tests #166

wants to merge 10 commits into from

Conversation

davidnevadoc
Copy link
Contributor

@davidnevadoc davidnevadoc commented Jun 25, 2024

Description

This PR refactors the field tests to achieve 2 goals:

  • More granularity: Unpack tests that were previously just 1. This allows us to spot the failures precisely quicker.
  • Reducing macro code.

Changes

  • Field tests refactor
  • Modification of unused PrimeField constants for quadratic-extension fields in BN and BLS curves.
  • Minor typos.

Future work

Do the same for curves.

@davidnevadoc davidnevadoc marked this pull request as ready for review September 22, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant