-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative tsconfig.json #37
Conversation
src/cli.ts
Outdated
@@ -96,6 +102,7 @@ const cwd = process.cwd(); | |||
*/ | |||
const sourcePath = normalizePath(argv.flags.src, true); | |||
const distPath = normalizePath(argv.flags.dist, true); | |||
const tsconfig = getTsconfig(undefined, argv.flags.tsconfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parseTsconfig
should be used here. getTsconfig
searches for a tsconfig.json file, but parseTsconfig
parses the tsconfig.json at a given path.
Thanks for the PR! Can you add a test? |
@@ -96,8 +102,9 @@ const cwd = process.cwd(); | |||
*/ | |||
const sourcePath = normalizePath(argv.flags.src, true); | |||
const distPath = normalizePath(argv.flags.dist, true); | |||
const tsconfig = parseTsconfig(argv.flags.tsconfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While parseTsconfig
should be used if a tsconfig file is passed in, it should default to getTsconfig
if it's not passed in.
For reference, it should look like this:
https://github.com/esbuild-kit/esm-loader/blob/332a0a0220dbb80de806ebb3a15ec7c3ce893bee/src/utils.ts#L13-L20
hey there, I wonder if @Pirosauro is still working on this PR? Otherwise I'd like to be assigned Cheers |
Fine by me! Feel free to branch off of |
🎉 This issue has been resolved in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See #36
--tsconfig
CLI flag