Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate using supybot.dynamicScope without an import #1544

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deprecate using supybot.dynamicScope without an import #1544

wants to merge 2 commits into from

Conversation

jlu5
Copy link
Collaborator

@jlu5 jlu5 commented Jul 1, 2023

Some notes:

  • I'm using UserWarning here because Python doesn't show DeprecationWarnings to the console by default. (I'm not sure if changing that would be a better option)

@jlu5 jlu5 requested a review from progval July 1, 2023 03:32
@jlu5
log: pass in all kwargs to logging.Logger._log
31f4aba 
This include kwargs like stacklevel and stack_info that were more recently added.
@jlu5
Deprecate using supybot.dynamicScope without an import (#1535)
9541ba7
@jlu5 jlu5 force-pushed the deprecate-dynamic-without-import branch from e17aa82 to 9541ba7 Compare August 12, 2023 22:36
@jlu5
Copy link
Collaborator Author

jlu5 commented Sep 3, 2023

I will probably defer this until we drop Python < 3.8 (Python 3.7 went EOL in June 2023), as those versions don't support the stacklevel argument to log.warning. I don't think it's worth adding compat code for these old branches given the current timeframe

@progval progval changed the base branch from testing to master May 5, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progval progval Awaiting requested review from progval

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jlu5