Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math: Round trailing nines up in @convert #1573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Math: Round trailing nines up in @convert #1573

wants to merge 1 commit into from

Conversation

progval
Copy link
Owner

@progval progval commented May 25, 2024

No description provided.

@jlu5
Copy link
Collaborator

jlu5 commented Jun 28, 2024

I'm honestly surprised that this code is so complicated. Would anyone actually complain if we used a fixed (or configurable?) max precision like 2 or 3 decimal places?

@progval
Copy link
Owner Author

progval commented Jun 28, 2024

I would.

2 is definitely too little (8/9 = 1.125) so I wouldn't feel comfortable with 3 either.

The complexity is because it tries to fix physics calculous rules, ie. output should have as many significant digits as the input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants