Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dco-check): exclude dependabot emails from dco-check #1781

Closed
wants to merge 1 commit into from

Conversation

andaaron
Copy link
Contributor

@andaaron andaaron commented Sep 9, 2023

This is the official solution from the dco-check maintainers for dependabot failures

See:
christophebedard/dco-check#123
christophebedard/dco-check#126

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is the official solution from the dco-check maintainers dependabot failures

See:
christophebedard/dco-check#123
christophebedard/dco-check#126

Signed-off-by: Andrei Aaron <[email protected]>
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #1781 (d88142c) into main (9fcb8a8) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
+ Coverage   91.61%   91.64%   +0.03%     
==========================================
  Files         135      135              
  Lines       25905    25905              
==========================================
+ Hits        23732    23740       +8     
+ Misses       1607     1601       -6     
+ Partials      566      564       -2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andaaron andaaron marked this pull request as ready for review September 9, 2023 11:34
@rchincha
Copy link
Contributor

What is the DCO story for dependabot alert fixes from GH? We do things the way we do since not sure if GH PRs will adhere to "By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license."

@andaaron
Copy link
Contributor Author

What is the DCO story for dependabot alert fixes from GH? We do things the way we do since not sure if GH PRs will adhere to "By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license."

They use Signed-off-by: dependabot[bot] <[email protected]>
But the issue is this email doesn't match the email in git configuration. So the script errors with a message such as:

Checking commits: 68a197d7ccc69d9117adda0f4d853d17c6d0d26e..e104c413bd65bc30312f40535359d63d0fa2626e

Missing sign-off(s):

	e104c413bd65bc30312f40535359d63d0fa2626e
		sign-off not found for commit author: dependabot[bot] 49699333+dependabot[bot]@users.noreply.github.com; found: ['dependabot[bot] <[email protected]>']

@rchincha
Copy link
Contributor

That is only one problem and is fix-able.

#1796
^ for example, this PR doesn't have the license language which says:
"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license."

@andaaron
Copy link
Contributor Author

andaaron commented Oct 6, 2023

Let's close this for now.

@andaaron andaaron closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants