fix(delete manifest): distinct behaviors for delete by tag vb delete by digest #2626
+1,347
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
force-pushed
the
delete
branch
2 times, most recently
from
790095b
to
324e080
Compare
andaaron
force-pushed
the
delete
branch
4 times, most recently
from
516a01f
to
ae975db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
==========================================
+ Coverage 92.69% 92.72% +0.02%
==========================================
Files 169 169
Lines 22529 22545 +16
==========================================
+ Hits 20884 20904 +20
+ Misses 1027 1023 -4
Partials 618 618 ☔ View full report in Codecov by Sentry. |
andaaron
force-pushed
the
delete
branch
2 times, most recently
from
c3bc15b
to
dc48944
Compare
…by digest In case of delete by tag only the tag is removed, the manifest itself would continue to be accessible by digest. In case of delete by digest the manifest would be completely removed (provided it is not used by an index or another reference). Signed-off-by: Andrei Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of delete by tag only the tag is removed, the manifest itself would continue to be accessible by digest. In case of delete by digest the manifest would be completely removed (provided it is not used by an index or another reference).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.