Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call the SearchBuilder one time per request #3157

Closed
wants to merge 1 commit into from
Closed

Only call the SearchBuilder one time per request #3157

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented May 14, 2024 •
edited
Loading

Fixes #3155

@cbeer
Copy link
Member

cbeer commented May 24, 2024

SearchBuilder already memoizes its return value, we're just asking for the hash with two different parameter sets (and maybe we shouldn't?):

#3160

@jcoyne
Copy link
Member Author

jcoyne commented May 24, 2024

Superceded by #3160

@jcoyne jcoyne closed this May 24, 2024
@jcoyne jcoyne deleted the one-time branch May 24, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SearchBuilder is called twice for each request.
2 participants
@jcoyne @cbeer