Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial fixes for 8.0.0-alpha #47

Open
wants to merge 6 commits into
base: gh-pages
Choose a base branch
from
Open

Tutorial fixes for 8.0.0-alpha #47

wants to merge 6 commits into from

Conversation

soniaconnolly
Copy link

Make some improvements to the 8.0.0-alpha tutorial after running through it. Each of these items is in a separate commit for ease of reviewing, and also I can revert individual commits if you don't want some of the changes.

  • Add catalog_controller.rb comment to ruby snippets to show where to make changes.
  • In the facet-fields page, update suggested code for super_special_facet_component.html.erb since the underlying code has changed and the suggested code resulted in an error
  • Fix typos in tutorial text
  • In the extending-catalog-controller page, update the instructions to fix the static_page_controller routes. The given instructions resulted in an error
  • Give a hint about how to show the list of tutorial pages under the Prev/Next buttons. It didn't occur to me to click the menu icon on the upper left, because I had used it to select between versions of the tutorial
  • Add the published URL (https://workshop.projectblacklight.org/) to the README so that the repo is more findable

@soniaconnolly
Add catalog_controller.rb hint comment to ruby snippets that go in th…
c1745a3 
…at controller
@soniaconnolly
Update suggested code for super_special_facet_component.html.erb
d18cbcc 
The code for FacetFieldListComponent has changed. New code copied
from https://github.com/projectblacklight/blacklight/blob/main/app/components/blacklight/facet_field_list_component.html.erb
@soniaconnolly
Fix typos
84db23b
@soniaconnolly
Update static_page routes in routes.rb so that the example works in e…
cd990b8 
…xtending-catalog-controller page
@soniaconnolly
Give a hint about the list of tutorial pages under the Prev/Next buttons
b96fb10 
It didn't occur to me to click on the menu icon in the upper left to get a list of tutorial pages,
because I had clicked an identical menu icon to choose which version of the tutorial to view.
There is no indication that the functionality of that icon has changed.
@soniaconnolly
Add published URL to README to make repo more findable
65af86f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soniaconnolly