Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected: External comms updated #92

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kierisi
Copy link
Collaborator

@kierisi kierisi commented Sep 19, 2024

Learning some hard lessons about GitHub 😅

This PR replaces #79 and should incorporate all of the PR review feedback except for the addition of a link to an htmlproofer section. I'll set that up in a separate PR and once merged, will patch it into the handbook section here.

@kierisi
Copy link
Collaborator Author

kierisi commented Sep 19, 2024

pre-commit.ci autofix

@kierisi kierisi marked this pull request as ready for review September 19, 2024 21:01
@kierisi
Copy link
Collaborator Author

kierisi commented Sep 19, 2024

@lwasser this is ready for review! it was easier to make a new PR, as I got stuck in a rebase loop that started pulling in unrelated files 🙈

I've checked it locally, and the build looks good. there should be three files to review. I believe I've pulled everything over from the last review (minus the htmlproofer piece, as it hasn't been written yet) and checked it twice so it should be close to done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants