Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement push-constants #574

Merged
merged 34 commits into from
Sep 17, 2024
Merged

Implement push-constants #574

merged 34 commits into from
Sep 17, 2024

Commits on Sep 9, 2024

  1. Initial implementation of push_constants

    @fyellin
    fyellin committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    efcc55b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into push-constant

    @fyellin
    fyellin committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    694410f View commit details
    Browse the repository at this point in the history

  3. Initial implementation of push_constants

    @fyellin
    fyellin committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e0bac8c View commit details
    Browse the repository at this point in the history

  4. Better handling of limits 

    Fix lint errors.
    @fyellin
    fyellin committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c131d72 View commit details
    Browse the repository at this point in the history

  5. One more lint error.

    @fyellin
    fyellin committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ca16d0b View commit details
    Browse the repository at this point in the history

  6. And one more typo.

    @fyellin
    fyellin committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5976ccd View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Change limits to use hyphens 

    Combine the code that accesses features and limits for adapters and devices, since they are almost identical.
Add an error for unknown limit
    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b1d07d0 View commit details
    Browse the repository at this point in the history

  2. Forgot to uncomment some lines

    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    06adb79 View commit details
    Browse the repository at this point in the history

  3. Removed a couple of more comments

    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    330a6a9 View commit details
    Browse the repository at this point in the history

  4. Fix typo in comment. 

    Minor cleanup.
    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cdc2d3c View commit details
    Browse the repository at this point in the history

  5. Move push_constants stuff to extras.py

    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e80d7a4 View commit details
    Browse the repository at this point in the history

  6. Fix flake and codegen

    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1adb413 View commit details
    Browse the repository at this point in the history

  7. Fix failing test

    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d425910 View commit details
    Browse the repository at this point in the history

  8. Linux is failing even though my Mac isn't. I have to figure out what'… 

    …s wrong. :-(
    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d39ffb7 View commit details
    Browse the repository at this point in the history

  9. And one last lint problem

    @fyellin
    fyellin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    53bc240 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. First pass at documentation.

    @fyellin
    fyellin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e57cb9f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into push-constant

    @fyellin
    fyellin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a87b470 View commit details
    Browse the repository at this point in the history

  3. First pass at documentation.

    @fyellin
    fyellin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    01603ba View commit details
    Browse the repository at this point in the history

  4. Merge with main

    @fyellin
    fyellin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e4975d5 View commit details
    Browse the repository at this point in the history

  5. Undo accidental modification

    @fyellin
    fyellin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f42dc36 View commit details
    Browse the repository at this point in the history

  6. See

    @fyellin
    fyellin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    64dcbeb View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into push-constant

    @fyellin
    fyellin committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d681be2 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Found one carryover from move to 22.1 that I forgot to include. 

    Undoing all typo mistakes and moving to a different push.
    @fyellin
    fyellin committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f31aaae View commit details
    Browse the repository at this point in the history

  2. Yikes. One more _api change

    @fyellin
    fyellin committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6776ae4 View commit details
    Browse the repository at this point in the history

  3. Yikes. One more _api change

    @fyellin
    fyellin committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1294efa View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into push-constant

    @fyellin
    fyellin committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4ed2712 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Almar Klein <[email protected]>
    @fyellin @almarklein
    fyellin and almarklein committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3ad2868 View commit details
    Browse the repository at this point in the history

  2. Update comments. 

    Comment @create_and_release as requested.
    @fyellin
    fyellin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2249a4b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into push-constant

    @fyellin
    fyellin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7a2b3e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Tiny change to get tests to run again.

    @fyellin
    fyellin committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    39e52b5 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Merge branch 'main' into push-constant

    @fyellin
    fyellin committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    20d2cec View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Almar Klein <[email protected]>
    @fyellin @almarklein
    fyellin and almarklein committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    087c4be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into push-constant

    @fyellin
    fyellin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9c728c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'main' into push-constant

    @Korijn
    Korijn committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6eba317 View commit details
    Browse the repository at this point in the history