Fix some small errors #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
reviewed
Sep 19, 2024
Korijn
approved these changes
Sep 19, 2024
|
I don't have sufficient privileges (write access) to do the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to delete one _release
Allow most of tests in test_wgpu_vertex_instance to run even if multi-draw-indirect isn't available. This will be useful in the future as we add more features. Also simplified the code a little bit.
Fixed one test where I believe naga's behavior is incorrect. I updated the test to accept either naga's current behavior or the behavior of the JS implementation.