multi_draw_indirect_counter #594
Draft
+212
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code is working now, but it wasn't working an hour ago, and I didn't really do anything to fix it. I want to make sure I understand what's going on before this is merged. But it's rather straightforward code. |
fyellin
commented
Sep 20, 2024
| Equivalent to:: | ||
| count = min(<u32 at count_buffer_offset in count_buffer>, max_count) | ||
| for i in range(count): | ||
| render_pass_encoder.draw_indirect(buffer, offset + i * 16) |
There was a problem hiding this comment.
Help! Sphinx is complaining about bad indentation here and on line 222. Surprisingly there is no complaint about the previous two occurrences of this line. Something to do with the <> on line 205?
I can't find any reasonable documentation on sphinx. How do I fix this??
…d up inside a function definition.
|
The naga bug is back. |
… works when we do the bug_patch, but not otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the final two functions.
Fix some typos I had previous made.