Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fetch_string_and_headers compat: raise in and out of pyodide #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 20, 2024

  1. fetch_string_and_headers compat: raise in and out of pyodide

    Currently only the not_in_pyodide will raise on non-success, because this
    is the default behavior of urllib, the in_pyodide will not, so I added a
    raise_for_status.
    
    It is better to raise, as otherwise the package parser will potentially
    get proper URL and not manage to parse it, and decide there is no
    wheels, while we actually just got an error (404, or maybe 500).
    
    In addition wraps both case in a custom local HttpStatusError, so that
    we can actually catch these errors in the right places when we encounter
    them.
    
    Also add handling for PyPI 404
    
    Now that warehouse set cors to 404, (pypi/warehouse#16339)
    we need to change the checked exceptions as there is no more network
    errors.
    Carreau committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5c98d90 View commit details
    Browse the repository at this point in the history