Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: infinite recursion on LoggerWrapper #138

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix: infinite recursion on LoggerWrapper #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions micropip/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,13 @@ def _set_formatter_once() -> None:


class LoggerWrapper:
__slots__ = ("logger", "_orig_level")

logger: logging.Logger
# need a default value because of __getattr__/__setattr__
logger: logging.Logger = None # type: ignore[assignment]

def __init__(self, logger: logging.Logger):
self.logger = logger
# Bypassing __setattr__ by setting attributes directly in __dict__
self.__dict__["logger"] = logger

def __getattr__(self, attr):
return getattr(self.logger, attr)
Expand Down
Loading