Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom wheel filename regex with standard packaging parse_wheel_filename #12917

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Replace custom wheel filename regex with standard packaging parse_wheel_filename #12917

wants to merge 1 commit into from

Conversation

notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Aug 16, 2024 •
edited
Loading

This will be marked ready for review once _ in wheel version file name has been deprecated, see #12914

@notatallshaw notatallshaw mentioned this pull request Aug 16, 2024
Merged
@notatallshaw
Copy link
Member Author

test_install_from_wheel_with_headers appears to be flaky, I was able to reproduce the failure locally initially, but on rerun I can no longer reproduce it.

@sbidoul
Copy link
Member

sbidoul commented Aug 16, 2024

Looks good :)

@notatallshaw notatallshaw added this to the 25.1 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.1
Development

Successfully merging this pull request may close these issues.
2 participants
@notatallshaw @sbidoul