Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pyrepl from PyPy #2

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

[WIP] pyrepl from PyPy #2

wants to merge 31 commits into from

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Mar 10, 2019

pypy/lib_pypy/pyrepl => pyrepl
pypy/extra_tests/test_pyrepl => testing

py3.6 branch

Ref: https://bitbucket.org/pypy/pypy/issues/2971
It was passing in `reader` for `returns_unicode` (which should be a
bool).  This does not change the behavior, but is less confusing.
Fix test_quoted_insert_repeat to use "key" instead of "self-insert" to
actually use qIHelp.
@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #2 into master will increase coverage by 0.37%.
The diff coverage is 68.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage    60.7%   61.08%   +0.37%     
==========================================
  Files          22       22              
  Lines        2171     2238      +67     
  Branches      317      326       +9     
==========================================
+ Hits         1318     1367      +49     
- Misses        743      764      +21     
+ Partials      110      107       -3
Impacted Files Coverage Δ
pyrepl/console.py 71.79% <ø> (ø) ⬆️
testing/test_wishes.py 100% <ø> (ø) ⬆️
pyrepl/completing_reader.py 29.93% <0%> (ø) ⬆️
pyrepl/unix_eventqueue.py 97.33% <100%> (ø) ⬆️
testing/test_reader.py 100% <100%> (ø)
pyrepl/commands.py 58.9% <100%> (+2.15%) ⬆️
pyrepl/historical_reader.py 39.9% <100%> (-0.29%) ⬇️
testing/test_basic.py 100% <100%> (ø) ⬆️
pyrepl/unix_console.py 53.16% <100%> (+0.72%) ⬆️
testing/test_unix_reader.py 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2394f1...63ce133. Read the comment docs.

Not required due to 640d111.
Should also have been removed in PyPy py3.6 branch with 58411:be161e2bc46a.
@blueyed
Copy link
Collaborator Author

blueyed commented Apr 24, 2019

Picked history nuking on py3 into https://github.com/blueyed/pyrepl/pull/4..
What a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants