Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed some contradictory code #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

isrcsy
Copy link

@isrcsy isrcsy commented Jul 24, 2023

in common/main.c, the cread_print_hist_list function is defined inside a #ifndef CONFIG_CMDLINE_EDITING defination. However, this code snippest is inside a bigger #ifdef CONFIG_CMDLINE_EDITING which begin its defination at line and ends it defination at line 916. So the function presence condition will never be met.

in net/bootp.c, the situation is similar, the code code snippest I have deleted precense condition will never be met due to the #ifndef CONFIG_CMD_DHCP(line 356 and 'else' in line 470) and the block itself presence condition #ifdef CONFIG_CMD_DHCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant