fix potential endless loop in merge #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid single segments lists without deletes as merge candidates, as they will be moved to a merge operation and filtered for merging in the next consider_merge_options call. In rare cases this may end up in a endless merge loop where only single segments where nothing is to be done are merged.
|
I can confirm that this seems to have solved both the possibly infinite loop and (even rarer case of) finishing successfully yet merge policy not taking effect due to not ever being called with |
fulmicoton
approved these changes
Jul 29, 2024
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
avoid single segments lists without deletes as merge candidates, as they will be moved to a merge operation and filtered for merging in the next consider_merge_options call. In rare cases this may end up in a endless merge loop where only single segments where nothing is to be done are merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid single segments lists without deletes as merge candidates, as they will be moved
to a merge operation and filtered for merging in the next
consider_merge_options call. In rare cases this may end up in a endless
merge loop where only single segments where nothing is to be done are
merged.
#2454
As alternative we could say the merge policy would need to handle that.