QXmppAccountMigrationManager: Make public the extensions getter/setter #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnjX
reviewed
Jul 1, 2024
lnjX
reviewed
Jul 1, 2024
pasnox
force-pushed
the
master-migrationmanager
branch
3 times, most recently
from
57f0679
to
8b984e3
Compare
This is needed because without that change applications can not store and use app specific data. By example Kaidan export and import its roster settings which requires that all migration tasks finished before importing roster related data.
pasnox
force-pushed
the
master-migrationmanager
branch
from
8b984e3
to
01097ed
Compare
lnjX
approved these changes
Aug 18, 2024
|
Sorry for the delay. I just noticed QXmppExportData is missing any documentation. Would you like to fix that? |
lnjX
force-pushed
the
master-migrationmanager
branch
from
944cbff
to
5a4c404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because without that change applications can not store and use app specific data. By example Kaidan export and import its roster settings which requires that all migration tasks finished before importing roster related data.
PR check list:
\since QXmpp 1.X,QXMPP_EXPORTdoc/doap.xmlclang-format -i src/<edited-file(s)> tests/<edited-file(s)>