Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct TLS #642

Merged
merged 23 commits into from
Jul 30, 2024
Merged

Direct TLS #642

merged 23 commits into from
Jul 30, 2024

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Jul 24, 2024 •
edited
Loading

Implements direct TLS connections and XEP-0368: SRV records for XMPP over TLS.

PR check list:

  • Document your code
  • Add \since QXmpp 1.X, QXMPP_EXPORT
  • Update doc/doap.xml

Funded by NLnet via NGI Assure.

@lnjX lnjX marked this pull request as draft July 24, 2024 22:02
@lnjX lnjX marked this pull request as ready for review July 29, 2024 13:56
lnjX added 23 commits July 30, 2024 17:39
@lnjX
Configuration: Add quint16 port getter
d46cf6d
@lnjX
Call static QSslSocket::supportsSsl() statically (everywhere)
ced23bf
@lnjX
Replace usage of QLatin1String()
15f8326
@lnjX
IncomingClient: Remove QXmppStream inheritance, use XmppSocket directly
983ced9 
QXmppStream is going to be dropped in favour of using small components
like XmppSocket directly and avoiding complicated inheritance relations.
@lnjX
IncomingServer: Remove QXmppStream inheritance, use XmppSocket directly
b89a271
@lnjX
OutgoingServer: Use std::chrono_literals
1625dde
@lnjX
OutgoingServer: Fix uninitialized quint16
39ee2f7
@lnjX
OutgoingServer: Fix QList::first() on temporary
03f8807
@lnjX
OutgoingServer: Use named constant for default xmpp-server port
cbd429d
@lnjX
OutgoingServer: Remove QXmppStream inheritance, use XmppSocket directly
c3059e8
@lnjX
OutgoingServer: Use Q_SLOT/Q_SIGNAL syntax
0fe3de8
@lnjX
tests: stream: Test XmppSocket instead of QXmppStream
4c33aab
@lnjX
Remove obsolete QXmppStream
3af5ddc
@lnjX
Rename QXmppStream.cpp -> Stream.cpp
5b3fe17
@lnjX
Client: Remove "QXmppStream" name from warning message
5878280
@lnjX
Client: Introduce ServerAddress struct (instead of QDns*Record)
8c79c94 
This will be useful for managing addresses of different connection
types.
@lnjX
Client: Use ServerAddress also for LegacySSL connections
e181389 
Do not use normal xmpp-client SRV records for connecting with direct
TLS.
@lnjX
XmppSocket: Support direct TLS connections
4797106 
The issue was that with direct TLS started() would be emitted twice
(on connect and on encryption). The solution is to make XmppSocket aware
of the connection type (TLS or TCP) and only emit started() in on
connect if the connection type is TCP.
@lnjX
Client: Implement connecting using direct TLS
8f1f79f 
Both record types are looked up now and direct TLS is preferred as it
saves one round trip and works better with firewalls.
@lnjX
Client: Set ALPN 'xmpp-client' protocol
f4610a0 
This is needed so that TLS protocol multiplexers work correctly and a
single port can be used for XMPP, HTTPS and possibly other protocols.
@lnjX
Client: Try both TCP and direct TLS when no SRV records could be found
30f465a
@lnjX
doc: doap: Mark 'XEP-0368: SRV records for XMPP over TLS' as complete
1120a6b
@lnjX
Client: Document new connection behaviour and SRV record handling
57349e7
@lnjX lnjX merged commit 88e50a0 into qxmpp-project:master Jul 30, 2024
10 of 15 checks passed
@lnjX lnjX deleted the feature/direct-tls branch July 30, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
section:client QXmpp Client type:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lnjX