Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up slice fallback and remove bit64 slice hacks #1707

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Clean up slice fallback and remove bit64 slice hacks #1707

wants to merge 4 commits into from

Commits on Sep 30, 2022

  1. Make vec_slice_fallback() fully handle fallback slicing 

    - Handles dim case
- Always restores as needed
- Which means R level shaped dispatch no longer proxy/restores
- R level shaped dispatch also no longer unclasses, which defeated the purpose of dispatching!
- Fixes `vec_is_restored()` to also ignore `dim` and `dimnames`
    @DavisVaughan
    DavisVaughan committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    e7f62d2 View commit details
    Browse the repository at this point in the history

  2. Remove bit64 hacks

    @DavisVaughan
    DavisVaughan committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5cc3262 View commit details
    Browse the repository at this point in the history

  3. NEWS bullet

    @DavisVaughan
    DavisVaughan committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    3a6e3c1 View commit details
    Browse the repository at this point in the history

  4. Test that [ is actually called now

    @DavisVaughan
    DavisVaughan committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    84d0dbe View commit details
    Browse the repository at this point in the history