Add handler scripts & periodic job for upstream image mirroring to ECR #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Priyankasaggu11929
force-pushed
the
mirror-images
branch
2 times, most recently
from
d74adc3
to
4a5b6b2
Compare
Priyankasaggu11929
force-pushed
the
mirror-images
branch
from
4a5b6b2
to
a5fa295
Compare
rajaskakodkar
requested changes
Mar 31, 2022
navidshaikh
reviewed
Mar 31, 2022
navidshaikh
requested changes
Mar 31, 2022
Priyankasaggu11929
force-pushed
the
mirror-images
branch
from
7dc50c9
to
2295edd
Compare
|
/retest |
update mirror-images periodics job to postsubmits update scripts/mirror-images/soure-images.yaml to currently used image tags update scripts/mirror-images/sync-upstream-images-with-ecr.sh to correct aws region
Priyankasaggu11929
force-pushed
the
mirror-images
branch
from
2295edd
to
6f442fb
Compare
|
Resolved all comments & fixed merge conflicts. cc: @rajaskakodkar |
|
Thanks @Priyankasaggu11929! Let's get this in post infra migration. /hold |
|
Post PR Merge steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR makes the following changes:
Cleanup:
Post PR Merge steps:
test-image& replace the spec > container > image in thepostsubmit-mirror-upstream-images-to-ecrpost-submit job.scripts/mirror-images/source-images.yamlfile to trigger the post-submit job.