adds client/server impl for relay-specs APIs
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub trait BlindedBlockRelayer { | ||
| async fn get_proposal_schedule(&self) -> Result<Vec<ProposerSchedule>, Error>; | ||
|
|
||
| // TODO: support cancellations? |
There was a problem hiding this comment.
note: from offline discussions, cancellations appear necessary to attract builders
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct SignedBidSubmission { | ||
| pub message: BidTrace, | ||
| pub execution_payload: ExecutionPayload, |
There was a problem hiding this comment.
I don't see execution_payload in the relay-specs, but I guess it is part of the flashbots relay response?
There was a problem hiding this comment.
its missing from the example and needs to be updated
its literally the entire point to accept a payload here
| /// Spawns the server on a new task returning the handle for it | ||
| pub fn spawn(&self) -> JoinHandle<()> { | ||
| let server = self.serve(); | ||
| let address = server.local_addr(); |
There was a problem hiding this comment.
nit: prefer addr to be consistent with local_addr and variable in serve above
alternatively, just write tracing::info!("listening at {}...", server.local_addr()); below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.