Fix fallback when Kubernetes versions list is unavailable #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript can't compute the type of the payload correctly without using a normal discriminated union; this doesn't look as nice, but at least it seems to work. Signed-off-by: Mark Yen <[email protected]>
If Rancher Desktop was previously started with a version, but the user wipes the `k3s-versions.json` cache and we fail to download a new copy, handle the error and disable Kubernetes instead of throwing an error. To make sure the user is aware of the issue, also pop a diagnostic to describe the situation. Signed-off-by: Mark Yen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we previously had Kubernetes enabled, then the user deletes the
k3s-versions.jsoncache and we fail to download a new one, we would previously fall over hard. This makes it so we automatically disable Kubernetes in that situation (and add a diagnostic so the user has a chance of figuring out what was wrong).Fixes #7484