Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the namespace filter to be selected after making selection in the dropdown #11966

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Sep 18, 2024

Summary

This adds a @click event handler to the namespace filter input. Doing this allows the input to be selected after making a selection in the dropdown.

Fixes #11928

Occurred changes and/or fixed issues

  • Add a @click handler to ns-filter-input input

Technical notes summary

This regression was introduced in #11762, which added a @click.prevent handler to prevent multiple events from quickly toggling the namespace filter dropdown from opened to closed.

An alternative solution to this PR would be to revert the change made in #11762 and redesign the solution entirely. I thought the solution presented in this PR to be more straightforward, the tradeoff being that it requires the special case for the @click handler.

Areas or cases that should be tested

  • Namespace Filter

Areas which could experience regressions

  • NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.10.0 milestone Sep 18, 2024
@rak-phillip rak-phillip self-assigned this Sep 18, 2024
@rak-phillip rak-phillip changed the title Bugfix/11928 focus filter Allow the namespace filter to be selected after making selection in the dropdown Sep 18, 2024
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kapture.2024-09-19.at.07.34.26.mp4

cnotv
cnotv previously approved these changes Sep 19, 2024
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit f9d6f31 into rancher:master Sep 19, 2024
30 checks passed
@rak-phillip rak-phillip deleted the bugfix/11928-focus-filter branch September 19, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace/Project Filter Search becomes unclickable after one option is selected
2 participants