Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linkify #5089

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update linkify #5089

wants to merge 4 commits into from

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Dec 1, 2023 •
edited
Loading

Updates linkify to newest version (4.1.3).

Note the import for linkify changed - instead of linkify/string, there is a package linkity-string

To test:

  • In a project in the local cluster
  • Create a secret and add a description of test https://www.rancher.com
  • From the secrets list, click on the secret just created
  • Verify that the description renders as a banner and that the text has been linkified, i.e:
  • Ensure that the link opens in a new tab
    image

Note: This PR is based off of the PR to update caniuselite

@nwmac nwmac added this to the v2.8.next1 milestone Dec 1, 2023
@nwmac nwmac self-assigned this Dec 1, 2023
mantis-toboggan-md
mantis-toboggan-md requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkify default behaviour changed in 3.0.0; we need to explicitly configure target="_blank" now https://github.com/Hypercontext/linkifyjs/blob/main/CHANGELOG.md#breaking-changes-1

@nwmac nwmac modified the milestones: v2.9.0, v2.10.0 Jun 21, 2024
@nwmac
Copy link
Member Author

nwmac commented Jul 16, 2024

@mantis-toboggan-md Updated to ensure detected links open in a new tab

@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox Awaiting requested review from richard-cox

@mantis-toboggan-md mantis-toboggan-md Awaiting requested review from mantis-toboggan-md

Requested changes must be addressed to merge this pull request.

Assignees

@nwmac nwmac

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nwmac @mantis-toboggan-md