Use gh nv-gha-aws CLI extension to generate credentials
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WS_ROLE_ARN is set
ajschmidt8
reviewed
Sep 17, 2024
| . devcontainer-utils-init-github-cli; | ||
|
|
||
| # Check whether the user is in one of the allowed GitHub orgs | ||
| local allowed_orgs="${AWS_GITHUB_ORGS:-${VAULT_GITHUB_ORGS:-nvidia nv-morpheus nv-legate rapids}}"; |
There was a problem hiding this comment.
Is there a reason to hardcode this list?
The organization allow list is already defined in the AWS role policy. The gh nv-gha-aws tool will throw an error if an organization that is not on this list attempts to get credentials.
There was a problem hiding this comment.
This list is override-able via envvar, so the orgs here are just defaults. This list is compared against the user's orgs, then only the orgs for which the user is a member are attempted.
| fi | ||
|
|
||
| # Check whether the user is in one of the allowed GitHub orgs | ||
| local allowed_orgs="${VAULT_GITHUB_ORGS:-nvidia nv-morpheus nv-legate rapids}"; |
There was a problem hiding this comment.
Same question about hardcoded orgs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nv-gha-awsCLI extensionnv-gha-awsto generate credentials ifAWS_ROLE_ARNis set