Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common volumes and volumeMounts #1937

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chainlink
Copy link
Contributor

@chainlink chainlink commented Feb 22, 2024

Why are these changes needed?

This allows for setting common volumes and volumeMounts between the head and workers pods

Extends: #1932

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@chainlink
Copy link
Contributor Author

@kevin85421 @Yicheng-Lu-llll Would you mind reviewing this one as well?

@kevin85421
Copy link
Member

Hi @chainlink, thank you for the PR! I discussed this with @morhidi yesterday. We may decide to expose a common podTemplate instead of exposing fields one by one. Exposing fields one by one may make the Helm chart hard to maintain. I will not review the PR until we finalize the way that we plan to proceed.

@chainlink
Copy link
Contributor Author

Sounds like a great feature! Just to confirm my understanding, that would get built in at the operator level instead of the helm chart, correct?

@morhidi
Copy link

morhidi commented Feb 23, 2024

Can this be done at helm level, without changing the CRD? That would be ideal.

@kevin85421
Copy link
Member

It is better not to expose it at the CRD level. Etcd has a limitation on CRD size, and KubeRay CRDs are large, so I am very careful when adding something as significant as a new podTemplate to the CRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants