fix: avoid hard-code Prometheus datasource id #2043
+26
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind providing more details about how you test this PR manually? These two files are not mentioned in the Ray documentation. In addition, these files haven't been updated for two years, so I am unsure whether they work or not. I need to manually test this PR. |
|
Thanks @kevin85421 . Steps include,
|
|
cc @Yicheng-Lu-llll would you mind reviewing this PR? |
The document doesn't include any service monitor or Pod monitor for the KubeRay operator Pod. Is Prometheus able to fetch the metrics? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently the kuberay-api-server and kuberay-controller-runtime Grafana dashboard hard coded the Prometheus data source id, which is not re-usable by people. Fixed the hard code.
Related issue number
Checks