docs(kuberay-operator): update argo cd guide #2240
Open
+10
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongbo Miao <[email protected]>
|
We have already moved most docs to Ray website. Would you mind opening a PR in the Ray repository? GitOps (ArgoCD, Flux) is something I want KubeRay to integrate well with. Are you interested in scheduling a chat so that I can understand more about how KubeRay can improve to better support ArgoCD? If you are interested in that, you can ping me in the Ray Slack workspace. My Slack handle is "Kai-Hsun Chen (ray team)". Thanks! |
|
Sounds good, I will open a pull there! |
|
Hmm I didn't find any Argo CD related document in the new website. Does it mean have to create a new document? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
New Argo CD today provide☺️
ServerSideApply=trueoption, so no need split to deploy any more.This article explains: https://www.arthurkoziel.com/fixing-argocd-crd-too-long-error
This "Server Side Apply" is actually a good practice https://kubernetes.io/blog/2022/10/20/advanced-server-side-apply/ and will be default option for future Kubernetes version.
Related issue number
Checks
You can see I successfully deployed: