infra: using cpu limits is not good, let's remove defaults #2253
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://home.robusta.dev/blog/stop-using-cpu-limits Signed-off-by: Aviad Shimoni <[email protected]>
2 tasks
kevin85421
reviewed
Jul 17, 2024
| @@ -27,7 +27,6 @@ resources: | |||
| # resources, such as Minikube. If you do whelm to specify resources, uncomment the following | |||
| # lines, adjust them as necessary, and remove the curly braces after 'resources:'. | |||
| limits: | |||
| cpu: 100m | |||
There was a problem hiding this comment.
I think we should not remove the resource limit because the deployment will fail if the namespace has a ResourceQuota set up. How about increasing it a bit if it is not enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://home.robusta.dev/blog/stop-using-cpu-limits
Why are these changes needed?
Related issue number
Relates to #2252, trying remove chocking limit on kuberay
Checks