Upgrade kustomization files to Kustomize v5 #2352
Open
+24
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oksanabaza
changed the title
|
@kevin85421 could you please have a quick look? |
Sure, sorry I didn’t know it was an urgent item for you all. I initially planned to review it after Ray Summit. |
|
@oksanabaza would you mind rebasing with the master branch? Thanks! |
kevin85421
reviewed
Sep 18, 2024
There was a problem hiding this comment.
I manually test deploying KubeRay operator by running:
kubectl create -k ray-operator/config/defaultmake deploy-with-webhooks
It works. @oksanabaza would you mind manually testing deploying KubeRay apiserver?
oksanabaza
force-pushed
the
kustomize
branch
from
462dc0f
to
0045c05
Compare
Could you provide some details in the PR description to explain how you tested deploying the KubeRay API server? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR addresses the migration from Kustomize v4 to v5. Kuberay was generating warnings about deprecated parameters, which have now been updated to align with Kustomize v5 standards.
Related issue number
Checks