Fall back to CPU requests if limit is not specified #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: Andrew Sy Kim <[email protected]>
andrewsykim
force-pushed
the
num-cpu-requests
branch
from
ba04cfb
to
db88862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Per discussion in #2361, it is common and often recommended that workloads specify CPU requests and NOT limits. This is to prevent premature CPU throttling from cgroups and underutilization of machine resources.
In KubeRay, you must specify limits to appropriately configure
--num-cpusflag in Ray. This PR makes limits optional by looking at CPU requests for num-cpus. We only check CPU requests if limits is not specified to avoid beaking existing deployments that rely on limits.Related issue number
Checks