[Feat][kubectl-plugin] Add dynamic shell completion for kubectl ray session #2390
+152
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession Signed-off-by: Chi-Sheng Liu <[email protected]>
|
The demo video looks good! Is it only for |
|
@kevin85421 Currently only session command. |
|
@MortalHappiness the autocomplete looks awesome, can't wait to try it!
@chiayi can we look into implementing similar autocompletion for |
andrewsykim
reviewed
Sep 19, 2024
| } | ||
|
|
||
| // RayJobCompletionFunc Returns a completion function that completes RayJob resource names. | ||
| func RayJobCompletionFunc(f cmdutil.Factory) func(*cobra.Command, []string, string) ([]string, cobra.ShellCompDirective) { |
There was a problem hiding this comment.
Is RayJobCompletionFunc and RayServiceCompletionFunc still needed? It looks like RayClusterResourceNameCompletionFunc handles resource type already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Implement dynamic shell completion for
kubectl ray sessioncommand.Note: I haven't found a proper way to mock the cmd Factory to get custom resources for testing.
Screencast:
2024-09-18.17-35-09.mp4
Related issue number
N/A
Checks