Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Core] Support of reading Working dir from HUAWEI Object Storage Service (OBS) #45577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imhy
Copy link

@imhy imhy commented May 27, 2024

This PR add ability to read working dir stored as archive in OBS.

Why are these changes needed?

User will be able to run submit tasks specifying the location of the working directory in OBS.

Related issue number

Changes made according to REP
PR to smart_open

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes please take this PR.

@imhy imhy force-pushed the obs_support branch 2 times, most recently from 3960b69 to 14638a3 Compare May 28, 2024 08:16
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels May 29, 2024
@edoakes
Copy link
Contributor

edoakes commented May 29, 2024

@imhy does smart_open already support obs:// URIs? Couldn't find anything on the docs -- please point me to it if you can

@imhy
Copy link
Author

imhy commented May 31, 2024

@imhy does smart_open already support obs:// URIs? Couldn't find anything on the docs -- please point me to it if you can

@edoakes Currently I`m working on extending smart_open, PR is open.

When this PR will be approved I will inform You.

@anyscalesam anyscalesam added P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core P2 Important issue, but not time-critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants